carmen-gh commented 6 years ago

I wanted to use IBLocalizable with option to install via Carthage, but it didn't work. Tried it in a small sample App. Tried the same with the CocoaPods installation and it worked.

PiXeL16 commented 6 years ago

Yeah, not sure what happened with Carthage. Do you have ideas? I don't really have a lot of time to dig into the project anymore. PRs are very welcome.

carmen-gh commented 6 years ago

I have no idea, but I will have a closer look. If I find a solution I will create a PR

ktakayama commented 6 years ago

16 will be fix of this problem.

PiXeL16 commented 6 years ago

I just merged #16 @camina-apps can you give it another try and report back if that works?

carmen-gh commented 6 years ago

@ktakayama @PiXeL16 still not working. I tried it with Xcode 9.3 and IBLocalizable 1.2.0

carmen-gh commented 6 years ago

Seems it is a general problem https://github.com/Carthage/Carthage/issues/335 https://openradar.appspot.com/23114017 https://stackoverflow.com/questions/29933691/ibdesignable-from-external-framework/37631860#37631860

PiXeL16 commented 6 years ago

I see, thanks for the research. I will let this one open in case others find it useful.

ktakayama commented 6 years ago

@camina-apps IBLocalizable 1.2.0 does not contain #16 . Please try this in your Cartfile.

github "PiXeL16/IBLocalizable" "f1c072437472684d4dc4560678283743112e5f73"

PiXeL16 commented 6 years ago

@ktakayama Not sure if I understand. Carthage its supposed to pull from master no?. And that should contain #16?. 1.2.0 it's the release version that its mostly used by the Podfile I believe.

ktakayama commented 6 years ago

Carthage will not build from master if you tagged any revision.

$ ls
Cartfile
$ cat Cartfile
github "PiXeL16/IBLocalizable"

$ carthage bootstrap --platform iOS
*** No Cartfile.resolved found, updating dependencies
*** Fetching IBLocalizable
*** Checking out IBLocalizable at "1.2.0"
*** xcodebuild output can be found in /var/folders/z5/br6wh4sd2n94072swvtchkk80000gn/T/carthage-xcodebuild.sZRBBh.log
*** Building scheme "IBLocalizable" in IBLocalizable.xcworkspace

$ ls
Cartfile  Cartfile.resolved  Carthage/

$ cat Cartfile.resolved
github "PiXeL16/IBLocalizable" "1.2.0"

$ ls
Cartfile

$ cat Cartfile
github "PiXeL16/IBLocalizable" "f1c072437472684d4dc4560678283743112e5f73"

$ carthage bootstrap --platform iOS
*** No Cartfile.resolved found, updating dependencies
*** Checking out IBLocalizable at "f1c072437472684d4dc4560678283743112e5f73"
*** xcodebuild output can be found in /var/folders/z5/br6wh4sd2n94072swvtchkk80000gn/T/carthage-xcodebuild.yh9QeT.log
*** Building scheme "IBLocalizable" in IBLocalizable.xcworkspace

$ ls
Cartfile  Cartfile.resolved  Carthage/

$ cat Cartfile.resolved
github "PiXeL16/IBLocalizable" "f1c072437472684d4dc4560678283743112e5f73"

ktakayama commented 6 years ago

The solution(#16) for this issue is the same way as HeroTransitions/HERO.... https://github.com/HeroTransitions/Hero/issues/307

carmen-gh commented 6 years ago

@ktakayama still not working. this has to be fixed https://openradar.appspot.com/23114017 by Apple. I even tried HeroTransition and it is not working for them ether

PiXeL16 / IBLocalizable

Not working with Carthage installation #14

16 will be fix of this problem.