PibePlayer / MultiMC5-Cracked

Cracked MultiMC launcher. Not related to original developers
Other
95 stars 64 forks source link

[IMPROVEMENT] Add a json playerlist instead of using a txt file #8

Open Xpl0itU opened 3 years ago

Xpl0itU commented 3 years ago

jsons are better for storing data, I already did most of the implementation except writing to it, so just reading atm

the default field is to be changed with a new button in the dialog called "Set as default", the selection dialog could also be avoided with that button or a new one

Link to the implementation

PibePlayer commented 3 years ago

I'm checking it out, I would argue that for simple data a raw txt is one of the fastest options, but json gives a lot of versatility while remaining almost as fast. I'll implement this, probably tomorrow. If you can, think more uses for the json, or a way to make this program even better :)

Xpl0itU commented 3 years ago

I would also suggest to completely remove the player selection dialog and instead rework the Accounts section in the settings, remove the “Launch Offline” button as doesn’t make any sense here and change the logged account thing in the top right with the current default account selected, these changes are just minor changes so I might do them myself

PibePlayer commented 3 years ago

@Xpl0itU Actually @Ponywka did that: Offline Patch with Profiles, but that is a totally different approach. As for the Launch Offline, I expect to add real functionality to it, being able to launch the game without checking for updates (so no need for internet connection ;) )