Commit 6935658 issue with no controllers in list

PickNikRobotics / abb_ros2

Apache License 2.0

82 stars 34 forks source link

Commit 6935658 issue with no controllers in list #58

Closed jodle001 closed 6 months ago

jodle001 commented 7 months ago

@Yadunund I am unable to get the controller to be recognized with this change if I do a fresh install. Am I doing something wrong that you can tell?

See below and it says that it says that there are zero controllers in the list. If I revert this commit, it works as normal.

24jsXgS

jodle001 commented 7 months ago

6935658e4944c7ff58067339aca4d0673297018f this commit

Yadunund commented 7 months ago

Could you provide more information:

OS, version of ROS 2 (whether binary or source install)
versions of moveit2, joint_trajectory_controller
what launch commands you used This would help reproduce the behavior. It would also help if you could paste your entire terminal input into a gist and share the link.

jodle001 commented 6 months ago

Ubuntu 22 ROS2 Hubmle Binary install
updated moveit2 binaries.
I'm using the commands pasted directly from the documentation here: https://github.com/PickNikRobotics/abb_ros2/blob/rolling/docs/README.md#simulating-a-robot-in-ros-2

Yadunund commented 6 months ago

So there are a few breaking changes between humble and iron and rolling binaries of ros2_controllers. I only tested with Iron and Rolling. I plan to fix the CI job in this repo later this week so I can investigate this further then. Maybe the workaround is to create a humble branch off the latest working commit.

Yadunund commented 6 months ago

Hi @jodle001

I think I found the issue. Could you try this PR https://github.com/PickNikRobotics/abb_ros2/pull/60?

I realized when I tested the commit that "broke" things, I had tested with a moveit config for a different robot which had the moveit_controllers.yaml file properly setup.