PickNikRobotics / data_tamer

C++ library for Fearless Timeseries Logging
MIT License
219 stars 21 forks source link

Colcon build error #11

Closed Alex-Beh closed 9 months ago

Alex-Beh commented 9 months ago

The project name is data_tamer_cpp or data_tamer? https://github.com/PickNikRobotics/data_tamer/blob/771bd8b9f4dc67182853b8cedf95230dc7250541/data_tamer_cpp/CMakeLists.txt#L3 https://github.com/PickNikRobotics/data_tamer/blob/771bd8b9f4dc67182853b8cedf95230dc7250541/data_tamer_cpp/package.xml#L3

--- stderr: data_tamer_cpp                                                                                                                                                           
CMake Error at /opt/ros/humble/share/ament_cmake_core/cmake/core/ament_package_xml.cmake:53 (message):
  ament_package_xml() package name 'data_tamer_cpp' in '/package.xml' does
  not match current PROJECT_NAME 'data_tamer'.  You must call project() with
  the same package name before.
Call Stack (most recent call first):
  /opt/ros/humble/share/ament_cmake_core/cmake/core/ament_package.cmake:63 (ament_package_xml)
  CMakeLists.txt:92 (ament_package)

Another error is

/src/data_tamer/data_tamer_cpp/include/data_tamer_parser/data_tamer_parser.hpp:45:19: note: ‘std::variant’ is only available from C++17 onwards
   45 | using VarNumber = std::variant<bool, char, int8_t, uint8_t, int16_t, uint16_t, int32_t,

Should we add the following line to cmakelist?

set(CMAKE_CXX_STANDARD 17)
facontidavide commented 9 months ago

fixed. thanks