search

PickNikRobotics / generate_parameter_library

Declarative ROS 2 Parameters
BSD 3-Clause "New" or "Revised" License
230 stars 43 forks source link

Fix newline issue #176

Closed pac48 closed 6 months ago

pac48 commented 6 months ago

Newlines were breaking the code generation for Python https://github.com/PickNikRobotics/generate_parameter_library/issues/170. This PR fixes the issue and reformats the C++ to print better with ros2 param describe... The following out shows the new format.

Parameter name: hover_override
  Type: integer
  Description: Override hover action:
    0: Hover
    1: Push
    2: Pull
    -1: Do not override
  Constraints:

The old format was like this 

Parameter name: hover_override
  Type: integer
  Description: Override hover action: 0: Hover 1: Push 2: Pull -1: Do not override
  Constraints:
pac48 commented 6 months ago

Looks fine for me.

Fyi, I have to change the parameter description of joint_trajectory_controller because I used \pi inside the description for rendering with sphinx -> without replacement of all \ it throws warnings now. But it still works, and output of ros2 param describe looks way better.

@christophfroehlich Do you mind giving this PR an approval review once you have made the changes you need to make to the joint_trajectory_controller?

saikishor commented 6 months ago

Hello!

Thank you for fixing it. When can we expect to have this fix released upstream?