PickNikRobotics / generate_parameter_library

Declarative ROS 2 Parameters
BSD 3-Clause "New" or "Revised" License
230 stars 43 forks source link

Drop yaml brackets for consistency and readability #203

Closed Timple closed 3 months ago

Timple commented 4 months ago

I noticed in some reviews internally that the brackets were used inconsistently. Turns out they were mostly copy pasted from the great parameter library.

May I suggest dropping the bracket syntax? It's yaml after-all, not json :slightly_smiling_face:

As you can already see in the first README example, it was a bit inconsistent, they are not used after turtlesim but are used after background.

Timple commented 3 months ago

So after the approval, what's next? :slightly_smiling_face: