Closed MarqRazz closed 1 month ago
Note this design was heavily influenced by rclpy.parameter.py's unpack_parameter_dict()
What do you think about supporting the yaml loading like they do in parameter_dict_from_yaml_file(). I tried to use this functionality but it's not in Humble and returns a Dict[str, ParameterMsg]
where generate_parameter's update()
takes a list of rclpy.parameter.Parameter
's. Personally I think it's fine for the user to have to load the dictionary from the correct namespace with yaml.safe_load(file)['my_param_namespace']['ros__parameters']
@pac48 do you have any thoughts about this approach? Is there anything I can do to help get this across the finish line?
@MarqRazz I added a small comment, otherwise looks good.
How does that look?
@pac48 can we run the tests?
This PR makes it so the
parameter_listener
can refresh it's copy of parameters with ones specified in a yaml dictionary and would close #208.To load and the get the parameters