Closed moriarty closed 1 year ago
Note this PR is entirely auto-generated. I'm expecting it to fail, and will fix it up accordingly
@abake48 or @MarqRazz I don't want to squash merge this PR because I want to easily revert specific commits in the future assuming either serial is released or there is a pure cmake version that we can depend on
:exclamation: No coverage uploaded for pull request base (
main@39df060
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #29 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 5
Lines ? 352
Branches ? 0
======================================
Hits ? 0
Misses ? 352
Partials ? 0
Flag | Coverage Δ | |
---|---|---|
unittests | 0.00% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Is the goal to have all test pass before we merge this PR?
Yes... I didn't expect this PR to take so long.
Do we expect each ros release to need a different
.repos
file? Would be nice if we could squash that down to a single file. This PR adds so many configuration files (but a lot of tests too!).
Basically the reason for each repo to have a uniq repos file is that they could require different branches...
@destogl has a script which sets this all up, and is what is used for the ROS 2 Control related repos.
I do agree that it pollutes the top directory with a bunch of stuff so maybe I re-organize and move them into a subdir
These will likely fail due to serial not being released for ROS2
I don't want to squash merge this PR