PickNikRobotics / ros2_robotiq_gripper

BSD 3-Clause "New" or "Revised" License
50 stars 40 forks source link

upstream: ros2_control deprecation replace fake with mock #32

Open moriarty opened 1 year ago

moriarty commented 1 year ago

This fixes the depreciation warning introduced upstream: https://github.com/ros-controls/ros2_control/commit/9d5d524c05e48035427f564d3a0e00c127e021e5

moriarty commented 1 year ago

Found a branch from @sea-bass and opening a Draft PR.

Since this package hasn't been released into humble yet I will try to get this change in. It is built on top of a branch from @eholum that also hasn't been merged.

sea-bass commented 1 year ago

@moriarty branch is rebased on main and contains just the changes we care about.

Again, if we can possibly cut a humble branch before this PR goes in and keep this one going forward as main, that would probably be best in terms of not breaking stable releases.

codecov[bot] commented 1 year ago

Codecov Report

Merging #32 (92567ee) into main (743d20f) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       5           
  Lines        352     352           
=====================================
  Misses       352     352           
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

moriarty commented 1 year ago

@sea-bass yeh that makes sense, I'll first do a 0.0.1 release without this change and then merge this after and create a humble branch.