search

PickNikRobotics / ros2_robotiq_gripper

BSD 3-Clause "New" or "Revised" License
50 stars 40 forks source link

Make Isaac topics configurable in URDF #38

Closed MarqRazz closed 9 months ago

MarqRazz commented 11 months ago

This PR makes it so the user can specify the topics that command and report state for the gripper in Isaac Sim.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 420 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (2bf5f68) 20.77%. Report is 7 commits behind head on main.

Files Patch % Lines
robotiq_driver/src/default_driver.cpp 9.09% 120 Missing :warning:
robotiq_driver/src/hardware_interface.cpp 11.82% 64 Missing and 18 partials :warning:
robotiq_driver/src/fake/fake_driver.cpp 0.00% 35 Missing :warning:
robotiq_driver/src/default_serial.cpp 22.72% 32 Missing and 2 partials :warning:
...botiq_driver/tests/test_default_driver_factory.cpp 34.28% 0 Missing and 23 partials :warning:
robotiq_driver/src/default_driver_factory.cpp 26.66% 3 Missing and 19 partials :warning:
robotiq_driver/src/default_serial_factory.cpp 29.16% 0 Missing and 17 partials :warning:
..._controllers/src/robotiq_activation_controller.cpp 0.00% 15 Missing :warning:
robotiq_driver/src/data_utils.cpp 55.88% 3 Missing and 12 partials :warning:
...botiq_driver/tests/test_default_serial_factory.cpp 44.44% 0 Missing and 15 partials :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== + Coverage 0.00% 20.77% +20.77% ========================================== Files 5 20 +15 Lines 352 597 +245 Branches 0 240 +240 ========================================== + Hits 0 124 +124 + Misses 352 341 -11 - Partials 0 132 +132 ``` | [Flag](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/38/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/38/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | `20.77% <21.34%> (+20.77%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.