update setup-ros to get pinned version of empy

moriarty commented 8 months ago

Bumping just setup-ros made everything else fail... :(

I'll try to bump everything and fix whatever breaks in this PR

codecov[bot] commented 8 months ago

Codecov Report

Attention: 420 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (98bb849) 20.77%. Report is 11 commits behind head on main.

Files	Patch %	Lines
robotiq_driver/src/default_driver.cpp	9.09%	120 Missing :warning:
robotiq_driver/src/hardware_interface.cpp	11.82%	64 Missing and 18 partials :warning:
robotiq_driver/src/fake/fake_driver.cpp	0.00%	35 Missing :warning:
robotiq_driver/src/default_serial.cpp	22.72%	32 Missing and 2 partials :warning:
...botiq_driver/tests/test_default_driver_factory.cpp	34.28%	0 Missing and 23 partials :warning:
robotiq_driver/src/default_driver_factory.cpp	26.66%	3 Missing and 19 partials :warning:
robotiq_driver/src/default_serial_factory.cpp	29.16%	0 Missing and 17 partials :warning:
..._controllers/src/robotiq_activation_controller.cpp	0.00%	15 Missing :warning:
robotiq_driver/src/data_utils.cpp	55.88%	3 Missing and 12 partials :warning:
...botiq_driver/tests/test_default_serial_factory.cpp	44.44%	0 Missing and 15 partials :warning:
... and 6 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== + Coverage 0.00% 20.77% +20.77% ========================================== Files 5 20 +15 Lines 352 597 +245 Branches 0 240 +240 ========================================== + Hits 0 124 +124 + Misses 352 341 -11 - Partials 0 132 +132 ``` | [Flag](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/45/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/45/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | `20.77% <21.34%> (+20.77%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moriarty commented 8 months ago

Some checks were not successful
11 failing and 6 successful checks

Some checks were not successful
4 failing and 15 successful checks

:thinking: a step closer but unfortunately I can't locally reproduce the failing xmllint test which is timing out... Will need to setup a docker container and test this a bit more

alex@alex-servalws:~/ros/h/kinova$ cat log/latest_test/robotiq_controllers/stdout.log 
UpdateCTestConfiguration  from :/home/alex/ros/h/kinova/build/robotiq_controllers/CTestConfiguration.ini
Parse Config file:/home/alex/ros/h/kinova/build/robotiq_controllers/CTestConfiguration.ini
   Site: alex-servalws
   Build name: (empty)
 Add coverage exclude regular expressions.
Create new tag: 20240208-1322 - Experimental
UpdateCTestConfiguration  from :/home/alex/ros/h/kinova/build/robotiq_controllers/CTestConfiguration.ini
Parse Config file:/home/alex/ros/h/kinova/build/robotiq_controllers/CTestConfiguration.ini
Test project /home/alex/ros/h/kinova/build/robotiq_controllers
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 1
    Start 1: cppcheck

1: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/cppcheck.xunit.xml" "--package-name" "robotiq_controllers" "--output-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/ament_cppcheck/cppcheck.txt" "--command" "/opt/ros/humble/bin/ament_cppcheck" "--xunit-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/cppcheck.xunit.xml" "--include_dirs" "/home/alex/ros/h/kinova/src/ros2_robotiq_gripper/robotiq_controllers/include"
1: Test timeout computed to be: 300
1: -- run_test.py: invoking following command in '/home/alex/ros/r/robotiq/src/ros2_robotiq_gripper/robotiq_controllers':
1:  - /opt/ros/humble/bin/ament_cppcheck --xunit-file /home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/cppcheck.xunit.xml --include_dirs /home/alex/ros/h/kinova/src/ros2_robotiq_gripper/robotiq_controllers/include
1: cppcheck 2.7 has known performance issues and therefore will not be used, set the AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS environment variable to override this.
1: -- run_test.py: return code 0
1: -- run_test.py: verify result file '/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/cppcheck.xunit.xml'
1/3 Test #1: cppcheck .........................   Passed    0.11 sec
test 2
    Start 2: lint_cmake

2: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/lint_cmake.xunit.xml" "--package-name" "robotiq_controllers" "--output-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/ament_lint_cmake/lint_cmake.txt" "--command" "/opt/ros/humble/bin/ament_lint_cmake" "--xunit-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/lint_cmake.xunit.xml"
2: Test timeout computed to be: 60
2: -- run_test.py: invoking following command in '/home/alex/ros/r/robotiq/src/ros2_robotiq_gripper/robotiq_controllers':
2:  - /opt/ros/humble/bin/ament_lint_cmake --xunit-file /home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/lint_cmake.xunit.xml
2: 
2: No problems found
2: -- run_test.py: return code 0
2: -- run_test.py: verify result file '/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/lint_cmake.xunit.xml'
2/3 Test #2: lint_cmake .......................   Passed    0.10 sec
test 3
    Start 3: xmllint

3: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/xmllint.xunit.xml" "--package-name" "robotiq_controllers" "--output-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/ament_xmllint/xmllint.txt" "--command" "/opt/ros/humble/bin/ament_xmllint" "--xunit-file" "/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/xmllint.xunit.xml"
3: Test timeout computed to be: 60
3: -- run_test.py: invoking following command in '/home/alex/ros/r/robotiq/src/ros2_robotiq_gripper/robotiq_controllers':
3:  - /opt/ros/humble/bin/ament_xmllint --xunit-file /home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/xmllint.xunit.xml
3: File 'controller_plugins.xml' is valid
3: 
3: File 'package.xml' is valid
3: 
3: No problems found
3: -- run_test.py: return code 0
3: -- run_test.py: verify result file '/home/alex/ros/h/kinova/build/robotiq_controllers/test_results/robotiq_controllers/xmllint.xunit.xml'
3/3 Test #3: xmllint ..........................   Passed    0.19 sec

100% tests passed, 0 tests failed out of 3

Label Time Summary:
cppcheck      =   0.11 sec*proc (1 test)
lint_cmake    =   0.10 sec*proc (1 test)
linter        =   0.40 sec*proc (3 tests)
xmllint       =   0.19 sec*proc (1 test)

Total Test time (real) =   0.40 sec

PickNikRobotics / ros2_robotiq_gripper

update setup-ros to get pinned version of empy #45

Codecov Report