PickNikRobotics / ros2_robotiq_gripper

BSD 3-Clause "New" or "Revised" License
50 stars 40 forks source link

bump version of always-upload-cache #46

Open moriarty opened 7 months ago

moriarty commented 7 months ago

I don't think this will fix the issue I think the issue is due to name: But I can't find github action documentation to back that up

codecov[bot] commented 7 months ago

Codecov Report

Attention: 434 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (ce1b0db) 20.29%. Report is 16 commits behind head on main.

Files Patch % Lines
robotiq_driver/src/default_driver.cpp 9.09% 120 Missing :warning:
robotiq_driver/src/hardware_interface.cpp 10.28% 70 Missing and 26 partials :warning:
robotiq_driver/src/fake/fake_driver.cpp 0.00% 35 Missing :warning:
robotiq_driver/src/default_serial.cpp 22.72% 32 Missing and 2 partials :warning:
...botiq_driver/tests/test_default_driver_factory.cpp 34.28% 0 Missing and 23 partials :warning:
robotiq_driver/src/default_driver_factory.cpp 26.66% 3 Missing and 19 partials :warning:
robotiq_driver/src/default_serial_factory.cpp 29.16% 0 Missing and 17 partials :warning:
..._controllers/src/robotiq_activation_controller.cpp 0.00% 15 Missing :warning:
robotiq_driver/src/data_utils.cpp 55.88% 3 Missing and 12 partials :warning:
...botiq_driver/tests/test_default_serial_factory.cpp 44.44% 0 Missing and 15 partials :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== + Coverage 0.00% 20.29% +20.29% ========================================== Files 5 20 +15 Lines 352 611 +259 Branches 0 250 +250 ========================================== + Hits 0 124 +124 + Misses 352 347 -5 - Partials 0 140 +140 ``` | [Flag](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/46/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/46/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | `20.29% <20.80%> (+20.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moriarty commented 7 months ago

Looks like this has been broken for some time, but was working at some point... Because they're failing on old open PRs too.

The CI jobs were added in this PR and setup and configured using a script, I might need to re-run that script

https://github.com/PickNikRobotics/ros2_robotiq_gripper/pull/29

moriarty commented 7 months ago

image image

https://github.com/orgs/community/discussions/26698

Ahh this is likely an issue in the project configuration which broke at some point due to refactoring or renaming... I'll check the settings

moriarty commented 7 months ago

image

The names that come up in the settings search menu and how the jobs are named seems to have changed or was always incorrect I have removed the expected checks for now.

Humble Binary Build - main / binary / humble main (pull_request)