PickNikRobotics / ros2_robotiq_gripper

BSD 3-Clause "New" or "Revised" License
56 stars 43 forks source link

update urdf mesh filenames to use package path instead of file find, for general remote usage of rviz #50

Closed panagelak closed 1 week ago

panagelak commented 4 months ago

Hello!

I have a use case that the driver is running on the robot (inside a docker) , and i monitor the robot in rviz from my laptop.

I noticed that when using file://$(find robotiq_description) instead of package://robotiq_description the workspaces on the two computers need to have the same absolute path in order for rviz to show the meshes properly, this pr solves this issue.

Thanks

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.03%. Comparing base (743d20f) to head (0af8a32). Report is 21 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ========================================== + Coverage 0.00% 40.03% +40.03% ========================================== Files 5 20 +15 Lines 352 527 +175 Branches 0 33 +33 ========================================== + Hits 0 211 +211 + Misses 352 311 -41 - Partials 0 5 +5 ``` | [Flag](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/50/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PickNikRobotics/ros2_robotiq_gripper/pull/50/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics) | `40.03% <ø> (+40.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PickNikRobotics#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.