Closed sea-bass closed 1 month ago
It does seem like ros2_control has thrown yet another curveball at us here... I'll take a look later if I can will myself to
Damn, thanks!
This is the PR that broke things -- fixing now https://github.com/ros-controls/ros2_control/pull/1585
Of course, this means that non-rolling CI will now fail, so CI stuff will need to be modified to be on different branches, etc.
I recommend that someone with admin power branch out humble
, iron
, and jazzy
branches and keep those respective distros' CI on those. Then, the top-level README with all the status badges should be updated.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.26%. Comparing base (
743d20f
) to head (2a735e6
). Report is 18 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you @sea-bass !
I was trying to use this package on Rolling / Ubuntu 24.04 and ran into this problem.
Found it was related to https://github.com/ros-controls/ros2_control/pull/1553, in which the
<mimic>
tags have been deprecated as this information is now looked up directly from URDF.So these tags, and command interfaces, for mimic joints, should be removed.
BTW: This fixes Rolling CI because of a unit test that broke due to the above changes
... though the Coverage build seems to be failing for another reason. Seems to be https://github.com/ros-tooling/action-ros-ci/issues/844
EDIT: fixed in https://github.com/PickNikRobotics/ros2_robotiq_gripper/pull/56
I also took the liberty of renaming
sim_ignition
tosim_gazebo
in accordance to my related PR to the Kortex repo: https://github.com/Kinovarobotics/ros2_kortex/pull/228. But I can concede and pull that out to a future PR.