Remove default arguments to make function calls not ambiguous

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz

771 stars 243 forks source link

Closed VictorLamoine closed 5 years ago

VictorLamoine commented 5 years ago

Fixes #73

Isn't there a better way to handle this problem in C++ ?! Like making one of the function preferred?

VictorLamoine commented 5 years ago

I have removed the color and scale default for these functions.

davetcoleman commented 5 years ago

It bothered me these functions have been existing for so long in this error state, so I made some unit tests to protect them in the future

VictorLamoine commented 5 years ago

I think we are good guys

davetcoleman commented 5 years ago

@mlautman i need another review