search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
769 stars 243 forks source link

`generateEmptyPose` suddenly removed #148

Open Dale-Koenig opened 4 years ago

Dale-Koenig commented 4 years ago

static void generateEmptyPose(geometry_msgs::Pose& pose); was removed in the latest master without deprecating it. This caused a few problems (it was used, for example, in moveit grasps). However, any active projects using the master branch have likely already updated, or are not using the function to begin with, so I am not sure it is worth putting back in.

That said, the sudden removal causes some complications with backwards compatibility, because the replacement static geometry_msgs::Pose getIdentityPose(); did not exist in the preivous release. Therefore, repositories using master will not compile with melodic-devel and vice versa. Perhaps we could add in static geometry_msgs::Pose getIdentityPose(); to melodic-devel, and add a deprecated attribute to generateEmptyPose?

Dale-Koenig commented 4 years ago

@davetcoleman @mlautman There are several people complaining about problems related to this in the Moveit Grasps repo.

davetcoleman commented 4 years ago

Hi @Dale-Koenig ,

I'm not really involved with development anymore :-( But I see this commit you are referring to. Can you create a PR to backport that to melodic-devel and the other requested changes?

mlautman commented 4 years ago

@Dale-Koenig I believe that the master branch of moveit grasps has been patched. Re-open if I am wrong about this

Dale-Koenig commented 4 years ago

@Dale-Koenig I believe that the master branch of moveit grasps has been patched. Re-open if I am wrong about this

The problem is when using melodic branches. With both on master it is fine, but the melodic branches are incompatible

davetcoleman commented 4 years ago

Sorry for the confusion!

Can you create a PR to backport that to melodic-devel and the other requested changes?