PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
769 stars 243 forks source link

Add option to never wait for subscriber #217

Closed MarqRazz closed 2 years ago

MarqRazz commented 2 years ago

This adds the option of remembering that the user does not want to wait for a publisher before sending the MarkerArray.

After setting up the object if the user calls visualtools->loadMarkerPub(false); the object will no longer wait for listeners on the marker topic.

codecov[bot] commented 2 years ago

Codecov Report

Merging #217 (c3e90cc) into ros2 (445b998) will increase coverage by 0.65%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             ros2     #217      +/-   ##
==========================================
+ Coverage   19.24%   19.89%   +0.65%     
==========================================
  Files           5        5              
  Lines        1772     1784      +12     
==========================================
+ Hits          341      355      +14     
+ Misses       1431     1429       -2     
Impacted Files Coverage Δ
include/rviz_visual_tools/rviz_visual_tools.hpp 11.53% <0.00%> (-4.47%) :arrow_down:
src/rviz_visual_tools.cpp 16.32% <0.00%> (+0.38%) :arrow_up:
src/remote_control.cpp 0.00% <0.00%> (ø)
src/tf_visual_tools.cpp 0.00% <0.00%> (ø)
tests/rvt_test.cpp 96.03% <0.00%> (+7.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445b998...c3e90cc. Read the comment docs.

vatanaksoytezer commented 2 years ago

@MarqRazz just to be keep in mind, do you want a release with this soon(ish), or you guys are using from source?

MarqRazz commented 2 years ago

We are from source so no rush on the release.