PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
769 stars 243 forks source link

[ros2] pass in parent frame for imarker #233

Closed mechwiz closed 1 year ago

mechwiz commented 1 year ago

This PR is essentially the same as https://github.com/PickNikRobotics/rviz_visual_tools/pull/159 except targeting the ros2 branch

@nbbrooks , @AndyZe , @tylerjw

vatanaksoytezer commented 1 year ago

Lgtm! @mechwiz need some small formatting changes for pre-commit to pass. Can you apply?

codecov[bot] commented 1 year ago

Codecov Report

Merging #233 (46b01d2) into ros2 (4fe7735) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             ros2     #233   +/-   ##
=======================================
  Coverage   19.77%   19.77%           
=======================================
  Files           5        5           
  Lines        1795     1795           
=======================================
  Hits          355      355           
  Misses       1440     1440           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mechwiz commented 1 year ago

done!