Open JafarAbdi opened 1 year ago
I'm adding python binding support for https://github.com/ros-planning/moveit_visual_tools, too! I think we should wait till that one is open before merging this
Merging #239 (648da88) into ros2 (4fe7735) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## ros2 #239 +/- ##
=======================================
Coverage 19.77% 19.77%
=======================================
Files 5 5
Lines 1795 1795
=======================================
Hits 355 355
Misses 1440 1440
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
So I'm testing with my Isaac Moveit Tutorials container with FastDDS and I can run the CPP version but when I run the python one all of the markers are not displayed.
My guess is that it's publishing them to fast and so some of the messages are getting dropped. It would also be nice if the program printed the same messages that the cpp one does...
Thanks for testing! I think that's expected, the demos aren't the same, I was so lazy to port the whole demo to python :D :D
If your busy lets just add a single print to the program saying it sent the markers for display. Right now the program just returns without letting the user know anything.
If your busy lets just add a single print to the program saying it sent the markers for display. Right now the program just returns without letting the user know anything.
Should be fixed now
Doesn't include the imarker_simple & tf_visual_tools