I know the filling up the namespace of the resetmarker said to be done for debugging reasons but filling it up with anything causes the Foxglove Studio to take this particular message and use the namespace to decide what namespace to remove:
#deleteAllMarkers(ns: string): void {
const clearNamespace = (namespace: MarkersNamespace): void => {
for (const renderable of namespace.markersById.values()) {
this.remove(renderable);
this.renderer.markerPool.release(renderable);
}
namespace.markersById.clear();
};
if (ns.length === 0) {
// Delete all markers on this topic
for (const namespace of this.namespaces.values()) {
clearNamespace(namespace);
}
} else {
// Delete all markers on the given namespace
const namespace = this.namespaces.get(ns);
if (namespace) {
clearNamespace(namespace);
}
}
}
Hello,
I know the filling up the namespace of the resetmarker said to be done for debugging reasons but filling it up with anything causes the Foxglove Studio to take this particular message and use the namespace to decide what namespace to remove:
https://github.com/foxglove/studio/blob/64be9e1756f4a027072eb2312a67da01122ff7e1/packages/studio-base/src/panels/ThreeDeeRender/renderables/TopicMarkers.ts#L194-L215
https://github.com/foxglove/studio/blob/64be9e1756f4a027072eb2312a67da01122ff7e1/packages/studio-base/src/panels/ThreeDeeRender/renderables/TopicMarkers.ts#L80-L81
I am suggesting we remove this one so that whole library could be used with Foxglove Studio too.