search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
771 stars 243 forks source link

Use Eigen allocator for vectors with Eigen structures #30

Closed VictorLamoine closed 8 years ago

VictorLamoine commented 8 years ago

Fixes #27 but breaks the API.

davetcoleman commented 8 years ago

I literally made the kinetic branch yesterday and broke a lot of API (removed deprecated functions) so am happy to merge this

davetcoleman commented 8 years ago

What about: "If you want to use the std::vector container, you need to include

#include <Eigen/StdVector>

" from here?

I think we should use the alias EigenSTL::vector_Affine3d instead - its much cleaner - as MoveIt! does - could you update this?

Thanks!

davetcoleman commented 8 years ago

Went ahead and did it myself, thanks for pointing this out! https://github.com/davetcoleman/rviz_visual_tools/commit/950ed43f62d264f01cc3c1f9250cb4fcf0592496