search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
769 stars 243 forks source link

Prompt function does not return a value #51

Open Froz3nArcher opened 7 years ago

Froz3nArcher commented 7 years ago

RvizVisualTools.prompt calls RemoteControl.waitForNextStep, which calls RemoteControl.rvizDashboardCallback. The prompt function gives no return, so there's no indication that of what the input was from the remote control. rvizDashboardCallback can handle up to four inputs, but waitForNextStep only offers a boolean output, which is then lost in the prompt function.

waitForNextStep and prompt should be modified to propagate the user's desired response in order to correctly handle the interface. There is currently no way to stop an activity using the prompt function - any response simple continues the sequence.

davetcoleman commented 7 years ago

There is currently no way to stop an activity using the prompt function

Ctrl-C would stop it ;-)

The other buttons are not fully implemented but could be used to stop the process.

A pull request is welcomed for improving the functionality of this package - though big changes would likely need to go into the lunar release.