PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
771 stars 243 forks source link

3.4.2 #57

Closed VictorLamoine closed 7 years ago

VictorLamoine commented 7 years ago

Can we bump the package version to 3.4.2 as 3.4.1 is already released? Otherwise I have no way of requiring the latest version in my projects using RVT!

davetcoleman commented 7 years ago

I use the bloom infrastructure to bump versions whenever I make a release - I don't see why we would bump versions without releasing this again to Kinetic. I can do that as soon as we get your new frame update feature in.

VictorLamoine commented 7 years ago

There must be something that I don't understand:

Tag version 3.4.1
Release 3.4.1
...
Add some features
...
Tag version 3.4.2
Release 3.4.2
...

Right now we are at step Add some features between 3.4.1 and 3.4.2. The latest binary version is 3.4.1, the latest source version is 3.4.1.

How can I specify in my project that I require the version 3.4.1 with the new features?

I thought it would be more like:

Tag version 3.4.1
...
Add some features
...
Release 3.4.1
Tag version 3.4.2
...
Add some features
...
Release 3.4.2
Tag version 3.4.3
...

That way, when 3.4.1 is released, the repository switches to 3.4.2. In that case at every moment the source version has a version number greater than the binary. This allows to specify 3.4.2 (so it must be installed from source because the binary from that version does not exist yet) in a package; thus the features added after 3.4.1.

I'm not sure I'm clear... But I hope so :smile:

VictorLamoine commented 7 years ago

You can release a new version, but I don't think it is useful to release just for one or two features. (my point is: it can wait)

davetcoleman commented 7 years ago

How can I specify in my project that I require the version 3.4.1 with the new features?

What tool are you using for this? wstool? You can specify a commit version, or just master, instead...

VictorLamoine commented 7 years ago

I use wstool. I didn't know I could specify a commit! I will take a look at that.