search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
771 stars 243 forks source link

ambiguous function call #62

Closed mcevoyandy closed 7 years ago

mcevoyandy commented 7 years ago

Noticed this tonight. The Eigen version does not have a default value for length. I assume the geometry_msgs version should match?

https://github.com/davetcoleman/rviz_visual_tools/blob/02579b4742fc6cba463a420de6ecf37bbfea1193/include/rviz_visual_tools/rviz_visual_tools.h#L759 https://github.com/davetcoleman/rviz_visual_tools/blob/02579b4742fc6cba463a420de6ecf37bbfea1193/include/rviz_visual_tools/rviz_visual_tools.h#L761

davetcoleman commented 7 years ago

your fix is https://github.com/davetcoleman/rviz_visual_tools/pull/63 correct?