search

PickNikRobotics / rviz_visual_tools

C++ API wrapper for displaying shapes and meshes in Rviz
772 stars 243 forks source link

fix qt5_use_modules missing error #80

Closed machinekoder closed 6 years ago

machinekoder commented 6 years ago

fix for https://github.com/PickNikRobotics/rviz_visual_tools/issues/79

simonschmeisser commented 6 years ago

this is deprecated, use

target_link_libraries( ... Qt5::Widgets ... )

instead. See http://doc.qt.io/qt-5/cmake-manual.html

davetcoleman commented 6 years ago

ping

machinekoder commented 6 years ago

@simonschmeisser Then imarker_simple_demo is missing the target_link_libraries.

davetcoleman commented 6 years ago

This CMake kungfu is beyond me, not sure who is correct...

simonschmeisser commented 6 years ago

@machinekoder but imarker_simple_demo is not using anything Qt ? Builds seem to work everywhere now that the changes from kinetic have been forward ported to bionic or do you still have issues? Please give some more info on what system, cmake version and Qt version you are using then. Otherwise I think this and the related issue can be closed.

davetcoleman commented 6 years ago

Closing this, feel free to re-open if needed.