PickwickSoft / pystreamapi

The Python Stream API Library offering Streams like you know from Java/Kotlin/Scala in Python with some cool extensions
https://pystreamapi.pickwicksoft.org/
GNU General Public License v3.0
29 stars 4 forks source link

#15 add comparator argument to sortedmethod #16

Closed garlontas closed 2 years ago

garlontas commented 2 years ago

Closes #15

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 0.15 ⭐ 0.17 ⭐ 0.02 👎
Method Length 25.79 ⭐ 26.31 ⭐ 0.52 👎
Working memory 4.54 ⭐ 4.62 ⭐ 0.08 👎
Quality 92.45% 92.22% -0.23% 👎
Other metrics Before After Change
Lines 355 372 17
Changed files Quality Before Quality After Quality Change
pystreamapi/init.py 99.17% ⭐ 99.17% ⭐ 0.00%
pystreamapi/streams/__base_stream.py 95.91% ⭐ 95.54% ⭐ -0.37% 👎
tests/test_base_stream.py 89.16% ⭐ 89.21% ⭐ 0.05% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.2% 56.2% Coverage
0.0% 0.0% Duplication