Closed WobblyRobbly closed 3 months ago
@jochemvandooren as we've added a Breaking Change i.e. will fail if the default model score isn't met (5.0) this should bump the version to 1.0.0 based on ?
## [1.0.0] - 2024-06-19
- Add `project_fail_under` configuration
- Add `fail_any_model_under` configuration
- **breaking:** - default values of `5.0` for `project_fail_under` and `fail_any_model_under` will cause command to exit return code 1
@jochemvandooren as we've added a Breaking Change i.e. will fail if the default model score isn't met (5.0) this should bump the version to 1.0.0 based on ?
## [1.0.0] - 2024-06-19 - Add `project_fail_under` configuration - Add `fail_any_model_under` configuration - **breaking:** - default values of `5.0` for `project_fail_under` and `fail_any_model_under` will cause command to exit return code 1
We're following semantic versioning, meaning if the major version is 0
, a breaking change will bump the minor version.
However no need for this to happen in the changelog file for this PR, this is done when releasing :)
@WobblyRobbly Thank you so much for your contribution! First external PR that we merged for this project 🚀 🥇 Looking forward to more of the same!
Thanks for all your help on this one !!
This pull request is for Issue #55
Decisions
fail_project_under
andfail_any_model_under
can be specified in thepyproject.toml
or via command line0.0
forfail_project_under
andfail_any_model_under
is setcli.py
and that required theEvaluation
instance to be returned fromlint_dbt_project
Please let me know your thoughts of potential changes
Closes #55