Bug: Silver medal with 10.0 project score

PicnicSupermarket / dbt-score

Linter for dbt metadata

https://dbt-score.picnic.tech

MIT License

84 stars 7 forks source link

Bug: Silver medal with 10.0 project score #61

Closed japborst closed 1 month ago

japborst commented 3 months ago

It appears one can get a 10.0 project score, but still a silver medal

My suspicion is that the score is actually rounded (e.g. 9.95).

ohksith commented 3 months ago

Unable to replicate fail_replicate

japborst commented 3 months ago

Let me add more info: in this case there are multiple models being scored. One of them has a rule violation (medium), which results in a 8.9 score for that model. All other (22x) models have a score of 10.0.

The following math is applied:

(22 * 10.0 + 8.9) / 23 = 9.95

Which is then a 10.0 when you round.

farmanp commented 3 months ago

@japborst - could you provide steps to reproduce this issue?