PicnicSupermarket / reactive-support

RxJava 2 utilities.
MIT License
29 stars 0 forks source link

Fix PIT JUnit 5 compatibility support #46

Closed Stephan202 closed 4 years ago

Stephan202 commented 5 years ago

The migration from TestNG to JUnit 5 broke support for mutation coverage calculation. This change restores support.

See also hcoles/pitest#284.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 336


Totals Coverage Status
Change from base Build 334: 0.0%
Covered Lines: 125
Relevant Lines: 144

💛 - Coveralls
ghost commented 4 years ago

DeepCode's analysis on #7d7de4 found:

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


:relaxed: If you want to provide feedback on our bot, here is how to contact us.

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     85.41%   85.41%           
  Complexity       54       54           
=========================================
  Files             5        5           
  Lines           144      144           
  Branches          1        1           
=========================================
  Hits            123      123           
  Misses           19       19           
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 742a527...7d7de4e. Read the comment docs.

Stephan202 commented 4 years ago

Since this PR was opened most Maven configuration was migrated to oss-parent; this particular issue was fixed by PicnicSupermarket/oss-parent#6.