PicnicSupermarket / reactive-support

RxJava 2 utilities.
MIT License
29 stars 0 forks source link

Use the Picnic OSS Maven Parent #73

Closed Stephan202 closed 5 years ago

Stephan202 commented 5 years ago

While there:

ghost commented 5 years ago

DeepCode Report (#5bf584)

DeepCode analyzed this pull request. There are no new issues.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 430


Totals Coverage Status
Change from base Build 400: 0.0%
Covered Lines: 125
Relevant Lines: 144

💛 - Coveralls
sandermak commented 5 years ago

Branch builds fine for me locally, did see some checksum validation warnings though (Maven):

[WARNING] Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a from picnic for https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom
[WARNING] Could not validate integrity of download from https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom: Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a
[WARNING] Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a from picnic for https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom

For the rest LGTM!

Stephan202 commented 5 years ago

Tnx for checking! Feel free to tick approve. :)

The checksum warnings are not in the Travis CI logs, so they're probably particular to our Nexus instance; I'll try to see whether flushing the caches helps.

Stephan202 commented 5 years ago

Hmm, turns out the issue is not with our Nexus deployment, but upstream after all. I filed MVNCENTRAL-5225.