Closed Stephan202 closed 5 years ago
DeepCode analyzed this pull request. There are no new issues.
Branch builds fine for me locally, did see some checksum validation warnings though (Maven):
[WARNING] Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a from picnic for https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom
[WARNING] Could not validate integrity of download from https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom: Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a
[WARNING] Checksum validation failed, expected bd4d05e97ec9dc0a5494412055df8f36bc8dbc27 but is 9eaf096e9f2b4ed7d5f866b09b5121f6eb85963a from picnic for https://nexus.global.picnicinternational.com/repository/maven-public/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.pom
For the rest LGTM!
Tnx for checking! Feel free to tick approve. :)
The checksum warnings are not in the Travis CI logs, so they're probably particular to our Nexus instance; I'll try to see whether flushing the caches helps.
Hmm, turns out the issue is not with our Nexus deployment, but upstream after all. I filed MVNCENTRAL-5225.
While there: