search

Picolab / indy-sdk

Apache License 2.0
2 stars 1 forks source link

NodeJS: Error during native compile step #3

Closed alexvoro closed 6 years ago

alexvoro commented 6 years ago

Hi,

Thank you for making the nodejs wrapper. I wanted to try it out on a mac and ran into some build issues. Is there something missing in the setup, or could you recommend the build steps?

After running: LD_LIBRARY_PATH=../../indy-sdk/libindy/target/debug npm i --save indy-sdk

Getting error on `node-gyp rebuild:

node-gyp rebuild

CXX(target) Release/obj.target/indynodejs/src/indy.o ../src/indy.cc:185:34: error: variable length array of non-POD element type 'v8::Local' v8::Local argv[argc];

Also I've tried cloning and rebuilding the repo, with "npm run-script rebuild" and getting the same error locally. The contents of the /indy.cc:185:34 are in the screenshot attached

screen shot 2018-04-30 at 13 56 27

Thank you!

farskipper commented 6 years ago

Ok, looks like you are trying the right things. What version of node are you using? node -v

farskipper commented 6 years ago

@alexvoro Just made a fix and pushed it. Also published indy-sdk@0.2.4

Let me know how it goes.

alexvoro commented 6 years ago

@farskipper The fix in + indy-sdk@0.2.4 worked, thanks lots.