Pictogrammers / pictogrammers.com

Code for Pictogrammers.com
https://pictogrammers.com
75 stars 17 forks source link

Pressing enter in the search box replaces the text with `undefined` #51

Closed abextm closed 1 year ago

abextm commented 1 year ago

Before You Begin

Describe the issue you are experiencing

Pressing enter in the search box replaces the text with undefined and does not search anything

Describe the behavior you expected

Pressing enter navigates you to a full search result page

Steps to reproduce the issue

  1. Press enter in the search box
  2. It is now undefined

Which browser are you experiencing the issue?

Firefox nightly 111.0a1 (2023-01-31) & Chrome 109.0.5414.74

Which operating system are you using to run this browser?

Arch Linux

Additional information

No response

mririgoyen commented 1 year ago

Thanks for the report. I've made changes so that when you press "Enter" in the search box, you do not lose your search term. The search mechanism happens as you type, so you should see the results directly beneath the search box in real-time. It's possible typing quickly and pressing Enter was hiding that fact, so with the changes I made, it should be more apparent.

Changes should be deployed in about an hour.