search

Pictogrammers / vue-icon

A Vue component to render an SVG path icon.
MIT License
26 stars 11 forks source link

Icon not showing #2

Closed ahsatha closed 4 years ago

ahsatha commented 4 years ago

The icon is not showing though the component renders correctly, it needs a viewBox default of 0 0 24 24 of course you can add the type prop

JamesCoyle commented 4 years ago

If you set the type prop to mdi it will set the size and viewbox defaults to match what Material Design Icons requires.

ahsatha commented 4 years ago

Yes, I know but don't you think this should be the default? It's a minor thing I know. And also the README doesn't show the possible values for the type prop

JamesCoyle commented 4 years ago

I don't want these components to be seen as just an mdi component so I don't really want to set a default that assumes the icon is on a 24x24 grid. If I were to set a default I think I'd maybe go for a 100x100 viewbox which makes all of the values of the path percentage values. At least that way an icon would show up by default and it would be clear you needed to adjust the viewbox.

I'm thinking of creating a new repo just for the default icon size and viewbox data so it's easier for all of these components to update to support new icon packs. Then that repo can document the possible values and the icon repos can just link to it.

ahsatha commented 4 years ago

I see your point now, you are right I was looking from the mdi perspective since that's what I'm using. Closing this now.