search

PidgeonTools / SuperProjectManager

Setup your Blender project folders the easy way!
GNU General Public License v3.0
55 stars 4 forks source link

Open Finder #16

Closed stareagle closed 3 years ago

stareagle commented 3 years ago

The addon works in macOS very well and the only issue I have had is that after you click the "build project" button, Finder isn't automatically loaded like explorer is in Win10. Is there a way to include a toggle to indicate which OS is being used and execute the appropriate code?

BlenderDefender commented 3 years ago

There is, I've tried to implement a solution for Mac OS, but unfortunately, I can't test it, because I have no Mac OS device. So the problem is not the toggle, the problem is that I don't know what the appropriate code for Mac OS is. If you can find a Developer using Mac OS, he may work on this. Till then, I guess I can't do anything about this issue, I'm sorry.

stareagle commented 3 years ago

I have a fix. In the main functions script replace the existing code for Darwin with subprocess.cal(["open", path"]). Ive tested this and it is working. Please take a look and if you need any macOS help please let me know.

BlenderDefender commented 3 years ago

Ok, I'll do this and I'll let you know if I need help with MacOS

BlenderDefender commented 3 years ago

Created a pull request, could you Test this on your device?

stareagle commented 3 years ago

Hi

OK dumb question, what do I do with a Pull Request. Git and I are not all that acquainted really sorry to say.

Stareagle

On Feb 19, 2021, at 6:42 PM, Blender Defender notifications@github.com wrote:

Created a pull request, could you Test this on your device?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BlenderDefender/blender_pm/issues/16#issuecomment-782458733, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFIEEVPX25LG5K7YOCKUGDS73ZPZANCNFSM4X4S73RA.

BlenderDefender commented 3 years ago

Well, here's the download link: https://github.com/BlenderDefender/blender_pm/archive/open_finder.zip

BlenderDefender commented 3 years ago

The pull request just means that I created a separate branch, so I don't mess up the main code in case I do something wrong

stareagle commented 3 years ago

Ah right now I get it. I must do a tutorial on GIT sometime. I do python coding for work and its something I really should do.

I installed the file you linked to and it works just fine…Good feeling having a fix of mine submitted

Cheers Stareagle

On Feb 19, 2021, at 6:52 PM, Blender Defender notifications@github.com wrote:

The pull request just means that I created a separate branch, so I don't mess up the main code in case I do something wrong

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BlenderDefender/blender_pm/issues/16#issuecomment-782462280, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFIEEU2RUNSUDFGZZU5YTDS732THANCNFSM4X4S73RA.

BlenderDefender commented 3 years ago

I learned Git with this free course, and I'm glad I did it. The accent is a bit strong, but you can still understand him without problems.