Pidgeot / python-lnp

Cross-platform re-implementation of the Lazy Newb Pack launcher.
ISC License
64 stars 10 forks source link

'Grey out' options that require DFHack when DFHack is not enabled. #118

Closed Pidgeot closed 4 years ago

Pidgeot commented 4 years ago

This would avoid some of the confusion I've seen lately over eg why TwbT or Gemset graphics weren't working, etc.

I imagine it would be pretty painful to go through all that code and distinguish unavailable, inactive, and active, so I'll just leave the thought here.

[Issue created by PeridexisErrant: 2016-02-08] [Last updated on bitbucket: 2016-02-14]

[Comment created by Pidgeot: 2016-02-14] Add validation for current configuration before launching Dwarf Fortress (fixes #112) Bump version number to 0.10f

→ <<cset 2a486b049ceb>>

[Comment created by Pidgeot: 2016-02-14] Skip TWBT options for print mode when DFHack is not enabled (see #112)

→ <>

[Comment created by Pidgeot: 2016-02-14] If the configuration is invalid, a dialog like this will pop-up when trying to start DF:

twbt_error.png

[Comment created by PeridexisErrant: 2016-02-09] For invalid state: it's not ideal UX, but I'd probably have the "Play" button pop up a dialogue box explaining the problem instead of launching DF.

[Comment created by Pidgeot: 2016-02-08] Checking if it's a valid combination wouldn't be too complex - we already check if DFHack and TWBT is present, and present different options if they aren't. It wouldn't be that complicated to move the check to happen on toggle.

The more complicated issue is - what should happen if you do get in an "invalid" state? If you have TWBT as your print mode and turn off DFHack, what should happen? What should happen if you install a graphics pack that specifies TWBT? If DFHack is turned off, should we skip the modes when you toggle the option, or just display a warning somewhere?