Pidgeot / python-lnp

Cross-platform re-implementation of the Lazy Newb Pack launcher.
ISC License
65 stars 10 forks source link

Mac - crash on trying to import from previous install #144

Closed Pidgeot closed 4 years ago

Pidgeot commented 4 years ago

When it crashes, I get this:

#!python

Running PyLNP 0.12 (OS: osx, Compiled: True)
WARNING: JSONConfiguration: File PyLNP.json does not exist
Traceback (most recent call last):
  File "python_lnp/launch.py", line 12, in <module>
  File "python_lnp/core/lnp.py", line 125, in __init__
  File "python_lnp/tkgui/tkgui.py", line 716, in on_query_migration
  File "python_lnp/tkgui/tkgui.py", line 723, in migrate_settings
  File "python_lnp/core/importer.py", line 122, in do_imports
  File "genericpath.py", line 72, in commonprefix
ValueError: max() arg is an empty sequence

One time it didn't crash:

#!python

Running PyLNP 0.12 (OS: osx, Compiled: True)
WARNING: JSONConfiguration: File PyLNP.json does not exist
Exception in Tkinter callback
Traceback (most recent call last):
  File "lib-tk/Tkinter.py", line 1410, in __call__
  File "python_lnp/tkgui/tkgui.py", line 723, in migrate_settings
  File "python_lnp/core/importer.py", line 122, in do_imports
  File "genericpath.py", line 72, in commonprefix
ValueError: max() arg is an empty sequence

[Issue created by jecowa: 2016-08-09] [Last updated on bitbucket: 2016-09-04]

[Comment created by Pidgeot: 2016-09-04] I believe this was fixed by pull request #69; feel free to reopen if it isn't after all...

[Comment created by PeridexisErrant: 2016-08-09] https://bitbucket.org/Pidgeot/python-lnp/src/default/core/importer.py#importer.py-122

Hmm. If path_pairs is empty - eg because no import paths are configured - that should be caught earlier. I'm not sure what the problem is...

[Comment created by jecowa: 2016-08-27] Resolved by pull request #68.

[Comment created by Pidgeot: 2016-08-29] @jecowa The issue should not be marked as resolved or closed until the fix is actually in the codebase, so I'm re-opening it.

[Comment created by carter_scottm: 2016-08-31] Issue #130 was marked as a duplicate of this issue.