Pidgeot / python-lnp

Cross-platform re-implementation of the Lazy Newb Pack launcher.
ISC License
64 stars 10 forks source link

Update to newer PyInstaller #155

Closed Pidgeot closed 4 years ago

Pidgeot commented 4 years ago

In the interest of being as up-to-date as possible, and allowing Python3-based builds eventually, it would be good to update to a newer PyInstaller than the 2.1 version I'm currently using for builds.

At the moment, Pillow is broken on Windows when using PyInstaller 3.2, seemingly due to changes in .egg file handling. Specifically, the entire .egg contents seem to be missing.

Also relevant is this issue, which explicitly points out the regression.

This is potentially fixable by specifying more hidden imports, but I haven't yet dug deep enough to figure out what. Alternatively, if PyInstaller fixes the open issue linked above, that might also resolve this problem on its own.

[Issue created by Pidgeot: 2016-05-09] [Last updated on bitbucket: 2017-05-06]

[Comment created by Pidgeot: 2016-07-10] PyInstaller 3.2 seems to work well on OS X, and due to a bug report for that platform, that's what will be used there.

Windows will be upgraded when it works, and unless there is a pressing need to upgrade Linux before then, those builds will be upgraded at the same time as Windows.

Pidgeot commented 4 years ago

With the move to Python 3 in v0.14, the version of Pyinstaller used for the builds has been updated to 3.6 (3.5 for Windows, but good enough).

This has required... some hacking of the .spec file, but this has at least allowed the Python upgrade.