Pidgeot / python-lnp

Cross-platform re-implementation of the Lazy Newb Pack launcher.
ISC License
65 stars 10 forks source link

Leading space in "colors/ Current graphics pack.txt" #161

Closed Pidgeot closed 4 years ago

Pidgeot commented 4 years ago

I've had a private bug report that this is breaking syncing via OneDrive for some people, as the filename is reverted to a version without a leading space. If this is a non-essential feature of the filename, can we just change it?

[Issue created by PeridexisErrant: 2017-09-07] [Last updated on bitbucket: 2017-09-17]

[Comment created by Pidgeot: 2017-09-07] The point of the space is to ensure that it gets placed first in the sort order, but I suppose we can come up with another way of accomplishing that...

[Comment created by Pidgeot: 2017-09-17] I've just changed it to use an underscore instead of a space. I've also added a custom comparison function to handle sorting.

The existing space-prefixed file will be deleted when the file would normally be updated (when installing a color scheme).

[Comment created by Pidgeot: 2017-09-17] Prefix "Current Graphics Pack" colorscheme with _ instead of space (fixes #146)

→ <<cset 41d8e99d5daf>>