PieKing1215 / InvMove-Forge

Minecraft Forge mod that adds the ability to walk around while in inventories
GNU Lesser General Public License v3.0
2 stars 1 forks source link

CTD when opening any GUI with Mekanism 10.1.x #13

Open anabsolutesloth opened 2 years ago

anabsolutesloth commented 2 years ago

Describe the bug

To Reproduce

  1. Install Mekanism 10.1.x, InvMove, and Cloth Config
  2. Open any GUI supported by InvMove (Vanilla inventory even)
  3. Crash

Crash Log https://paste.ee/p/hCJ4X

Version and Mod List List the version of InvMove, the version of Forge, and the version of Minecraft the issue happens on: InvMove: 0.4.6 Forge: 36.2.31 Minecraft: 1.16.5

List any other mods being used (other than Cloth Config): Modlists of Enigmatica 6 1.0.0, Valhelsia 3.5.1 And a custom pack with, Architectury, Curios, JEI, KubeJS OpenLoader, Patchouli, and Rhino

I am aware this branch of the mod has been dropped, but with Mekanism being such a staple 1.16 modpacks, this makes InvMove outright unusable in the majority of packs, so even finding a workaround with other users of the mod would be great for those who want to use the mod on 1.16.

PieKing1215 commented 2 years ago

Thanks for the report! Yeah I'm not opposed to patching this since Mekanism is so popular. The last version I built with was 10.0.21 I think so it probably wouldn't be much work to update it assuming the dev environment didn't randomly stop working.

Maybe to help if this kind of thing happens again I'll add a way to manually (might be possible to catch this error automatically too) disable individual mod compats, so it'll just go through to the unrecognized section? That way you'd at least be able to stop it from crashing when mod updates inevitably break the compatibility. I cant think of any other workarounds other than like manually editing the bytecode of the jar to break the mekanism detection which isn't exactly user friendly

(fwiw this kind of problem is why in the new version of invmove I'm only explicitly supporting mods that actually require dedicated support like rei/jei, and then just depending on the new and improved "unrecognized" section to handle trivial uis which covers like 95% of mods)