[BO] Apply lib phone number API

[lcaohoanq]

https://github.com/PiedTeam/NikeCloneTraining-BE-Project/issues/137#issuecomment-2150482508 Based on research in the previous sprint, change all API related to phone number method to the new lib

[!note] Need to make sure this change not impact on FE

[minhhy2801]

You haven't finished research solution, how could u inprocess this ticket?

[lcaohoanq]

You haven't finished research solution, how could u inprocess this ticket?

Ah, when open this issue and #137, I think both oh theme can do parallel, does i need to revert this to backlog or keep in current status

[lcaohoanq]

cc @minhhy2801

After discussion with @hoangday185 and @nnh53, we divide this issue to smaller feature:

• @nnh53 will find many available firebase app, config them
• @hoangday185 will handle when the app reach to the limit OTP send
• I will refactor the current send otp module, ensure will send OTP to the client successfully (client will receive the sms message below)

[lcaohoanq]

• Considering point;
  • The delay when send sms to phone (in hosting enviroment) depend on client network, region ....
  • Stress test (integration test,...) for statitistic the percent of fail case
  • Does the provider have the document for Error Code
  • Identity the senario when user press the send OTP button again, they are facing with the OTP trouble (except the spam way)
  • Firebase 10th request or 11th

Frontend will not impact, Backend fixing the current function in api /send-otp-phone

Refs:

• https://cloud.google.com/identity-platform/docs/error-codes
• https://groups.google.com/g/firebase-talk/c/v2P11NmPrwo
• https://community.kodular.io/t/otp-message-late-or-not-received/154153/43?page=3
• https://status.firebase.google.com/summary
• https://groups.google.com/g/firebase-talk/c/OE0HPTFLPlg
• https://firebase.google.com/pricing
• https://firebase.google.com/docs/app-check/web/recaptcha-provider?hl=vi
• https://firebase.google.com/docs/auth/web/phone-auth?hl=vi

[lcaohoanq]

cc @minhhy2801

After discussion with @hoangday185 and @nnh53, we divide this issue to smaller feature:

• @nnh53 will find many available firebase app, config them
• @hoangday185 will handle when the app reach to the limit OTP send
• I will refactor the current send otp module, ensure will send OTP to the client successfully (client will receive the sms message below)

@hoangday185, @nnh53

• My raw estimate point about the task (base on date and the complex: 1 day ~ 1 point ~ 6 hours)

  1. Write config for mapping the id, replace current app_id to config firebase (2): @nnh53
  2. Implement the new Send OTP API (1) @Buicongbang04
  3. Handle fail (Continue to investigate...)

• Buffer (Phát sinh)

  • Take 30% total estimate point
  • Total:

[lcaohoanq]

trong truong hop no fail thi lam cach nao moi nhan duoc, hoac co cach nao do, nhin thay no that binh thuong nhat, neu thay verify cua authentication cua firebase no tot hon thi minh se dung hoac api hien tai tot hon

[lcaohoanq]

cc @minhhy2801

• Deployment for testing: https://react-firebase-authentication-rouge.vercel.app/
• The problem when i can send 17 sms (more than 10) due to the timezone reset free plan in different country (San Francisco, California, United States & Vietname) where Firebase company are located at. The difference are in 10 hours (VN: 14h, Cali: 24h)

• I found the document about error code for Firebase Authentication services:
• https://firebase.google.com/docs/reference/js/auth#autherrorcodes

Start sending total 7 request sms with +84934162561, all resolve, but come to 8th request, receive error:

• code: 400
• message: TOO_MANY_ATTEMPTS_TRY_LATER

• Waiting about minute, i still receive the error above

Change to use other phone +84979083300, it's work, reolsve and i can receive the OTP

• Best case:

  • User press send OTP button and receive on there phone imediately
  • User type the OTP back to verify there account

• Case are considering:

  • User receive OTP but not use to verify (1 time)
  • User request to receive OTP many times (hacker or user can't receive OTP)
  • User request to receive OTP many times, not use to verify (hacker or user can't receive OTP)
  • User can't receive OTP, trouble can be:
  • Firebase Server
    • Reach to request limit (free plan, Firebase called Sparks plan)
  • Network Issue
  • Telecom service provider (Mobifone, Viettel, Vinaphone,...)
  • User wait too long to receive the sms:
    • In my test, on both local and deployment (Vercel) the speed mostly consistent (<=10 seconds)

• So the goals is

  • Estimate success | error in sending (one phonenumber in certain time, more than one in certain time, or in different time)
  • Until now to weekend, i will have the table to overview
  • When it fail, how can we still send sms to the user? The fail case in test are
  • 1.
    • code: 400
    • message: TOO_MANY_ATTEMPTS_TRY_LATER
    • solution: if meet this error, user are in case considering
      • User request to receive OTP many times (in case user are hacker, i don't know how to prevent, but in case normal user, we will switch to new Firebase configuration imediately make sure the App enough for at least one request)
  • 2.
    • code: 400
    • message: QUOTA_EXCEEDED: Exceeded quota
    • solution: switch to new Firebase configuration
  • 3. Switched to the new Firebase and keep facing error: There someting unusual (Firebase may remark the phonenumber)
       • Receive same error
       • Receive different error
       • solution:

@nnh53, in the time switch app configuration, how many time does it take? (in average)

[lcaohoanq]

[Continue to estimate]

• https://docs.google.com/spreadsheets/d/1tKq_trQW0b99qhlAL69XEbFTuE8ETODwXTF_7A8cF00/edit?gid=0#gid=0

[Overview result]

• Maximum 10 request per day
• Reach the limit receive response
  • status: 400
  • message: INVALID_APP_CREDENTIAL
  • 
• Sometime we do not have enough 10 request sending (~8, 9) and receive the response above
• OTP if send in the near time can have the same value (double, tripple)

[lcaohoanq]

@nnh53 @Buicongbang04 I've update your task, Ms.Minh need to tell her the process of the task in your report tomorrow