Pier1 / rocketbelt

Rocketbelt is a UX-focused, responsive, and mobile-first pattern library collaboratively assembled at Pier 1 Imports.
http://rocketbelt.io
MIT License
9 stars 15 forks source link

color(gray, plus5) throws an error #158

Closed sliptype closed 6 years ago

sliptype commented 6 years ago

According to the docs, grayscale color variants should range from plus5 to minus2.

background-color: color(gray, plus5);

Results in

`` >> Error: Color variantplus5does not exist in familygray`.

    on line 16 of ../pier1_core/cartridge/css/vendor/rocketbelt/tools/functions/_color.scss
  @error 'Color variant `#{$variant}` does not exist in family `#{$family}```

However, plus4 through minus2 work fine.

kendrick commented 6 years ago

Have you synced with upstream recently? plus5 was added as a new variant a while back and is being used to render styles for tables.

sliptype commented 6 years ago

I was running 1.13.2 but upgrading to 1.13.4 did not resolve the issue

kendrick commented 6 years ago

I think this may be a combination of .npmignore being too greedy and one of the Gulp tasks not copying Sass files to the right place. Investigating…