Pierce01 / MinecraftLauncher-core

Lightweight module that downloads and runs Minecraft using javascript / NodeJS
MIT License
356 stars 81 forks source link

Fixing launcher errors by assigning two jsons #112

Closed HURROLED closed 11 months ago

HURROLED commented 1 year ago

This fixes custom versions that don't provide all necessary arguments in their version.json, so I think it will be right if we assign two objects with the priority of custom version.json.

Pierce01 commented 1 year ago

Launching forge using this PR results in

joptsimple.MultipleArgumentsForOptionException: Found multiple arguments for option launchTarget, but you asked for only one

version: 1.19.4 forge installer: forge-1.19.4-45.1.0-installer.jar

HURROLED commented 1 year ago

Check out a new commit that doesnt modify version json and works well with forge