Assets are not downloaded properly in some cases.

Pierce01 / MinecraftLauncher-core

Lightweight module that downloads and runs Minecraft using javascript / NodeJS

MIT License

361 stars 82 forks source link

Assets are not downloaded properly in some cases. #12

Closed breadfish18 closed 5 years ago

breadfish18 commented 5 years ago

OS: Debian MC Version: 1.13.2

On first launch on a empty directory as the root dir, the game crashes immediately. On the second launch game crashes when a menu button is pressed (and the game complains about missing pack.mcmeta). Third launch, the game launches fine with no missing assets. After replicating this many times, it happens every time.

7bitlyrus commented 5 years ago

I was able to reproduce using Debian Stretch 9.9 x64 and Minecraft 1.13.2 on version 3.5.3 (fafd828).

It seems to be specific to Debian. I tested on other OSes and wasn't able to reproduce on:

Windows 7 SP1 x64
Linux Mint 19.1 Tessa x64
Ubuntu 18.04.2 LTS x64

Quickly checking the assets folder, most but not all assets were 0 bytes.

7bitlyrus commented 5 years ago

At least for me, the issue on my Debian testing system seemed to be an intermediate networking issue. I submitted a PR (#15) that adds debug messages for downloading errors that would better help debug the issue you have.

Pierce01 commented 5 years ago

Woops.

Anyways, I believe this was solved in the latest update. I'll keep this open until the author of the issue responds

7bitlyrus commented 5 years ago

Just checked, I am no longer getting any issues using my aforementioned Debian install.

Pierce01 commented 5 years ago

Author hasnt responded and the issue seems to be fixed, closing.