Pierce01 / MinecraftLauncher-core

Lightweight module that downloads and runs Minecraft using javascript / NodeJS
MIT License
362 stars 83 forks source link

Forge/NeoForge 1.21.1 not working #127

Open Seeroy opened 1 month ago

Seeroy commented 1 month ago

I have problems running the above versions tomate-loaders is used to generate the startup configuration Launch configuration:

{
    "root": "F:\\clinstall",
    "version": {
        "number": "1.21.1",
        "type": "release",
        "custom": "neoforge-1.21.1"
    },
    "forge": "F:\\clinstall\\versions\\neoforge-1.21.1\\neoforge.jar",
    "memory": {
        "min": 1500,
        "max": 7680
    },
    "authorization": "removed",
    "javaPath": "F:\\clinstall\\javaDownloads\\21\\jdk-21.0.4+7\\bin\\java.exe",
    "customArgs": [],
    "customLaunchArgs": [],
    "overrides": {
        "maxSockets": 1
    },
    "window": {
        "fullscreen": false
    }
}

Tried:

Some logs:

Caused by: java.lang.module.ResolutionException: Modules org.apache.logging.log4j.slf4j2.impl and org.apache.logging.log4j.slf4j export package org.apache.logging.slf4j to module coremods
Caused by: java.lang.module.ResolutionException: Modules org.apache.logging.log4j.slf4j2.impl and org.apache.logging.log4j.slf4j export package org.apache.logging.slf4j to module patchy
Seeroy commented 1 month ago

Launch arguments.txt

Pierce01 commented 1 month ago

Issue found. https://discord.com/channels/568550848871923723/568552422247759884/1294302988890013737

Both of the following libs are being pushed to the classpath. Removing the 2.19.0 jar from the version manifest seems to resolve the issue. log4j-slf4j2-impl-2.19.0.jar log4j-slf4j2-impl-2.22.1.jar

Pushing a fix asap