Request library is deprecated!

Pierce01 / MinecraftLauncher-core

Lightweight module that downloads and runs Minecraft using javascript / NodeJS

MIT License

359 stars 82 forks source link

Request library is deprecated! #36

Closed Coder-Iro closed 4 years ago

Coder-Iro commented 4 years ago

[1/4] Resolving packages...
warning minecraft-launcher-core > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...

Coder-Iro commented 4 years ago

PLZ use axios library instead of request

Pierce01 commented 4 years ago

Hi! I'll look into the other libraries out there for the best one, however I'm out on college visits so I won't be able to for a day or two.

Pierce01 commented 4 years ago

Hello, lowkey forgot this issue was opened. I'm planning a rework on the handler file before I go off to college so I'll probably end up using another library like Axios or SA when that rolls around. Thanks for using the project!

artegoser commented 1 year ago

I can try to rewrite it myself after July 1 and send a pull request @Pierce01