search

Pierce01 / MinecraftLauncher-core

Lightweight module that downloads and runs Minecraft using javascript / NodeJS
MIT License
359 stars 82 forks source link

Split large MCLCore#launch into multiple methods #63

Closed KevSlashNull closed 3 years ago

KevSlashNull commented 3 years ago

This PR splits up the MCLCore#launch method into multiple smaller methods which should increase the readability.

It should not change any functionality.

KevSlashNull commented 3 years ago

Hey @Pierce01, could you please review this PR to refactor the components/launcher.js a bit? :bow:

Pierce01 commented 3 years ago

I will definitively check this out in a bit! Thank you so much for contributing, Kev!

Pierce01 commented 3 years ago

Though, now that I realize it, the TS types need to be added, right?

KevSlashNull commented 3 years ago

Though, now that I realize it, the TS types need to be added, right?

@Pierce01, depends on if we want to expose the methods. I think it’s okay to add them as private or protected methods because they serve no use to the developer and should be hidden.