PierfrancescoSoffritti / android-youtube-player

YouTube Player library for Android and Chromecast, stable and customizable.
https://pierfrancescosoffritti.github.io/android-youtube-player/
MIT License
3.44k stars 765 forks source link

feat: add getVideoIdFromUrl to get id #1139

Closed MahmoudMabrok closed 6 months ago

MahmoudMabrok commented 6 months ago

apply issues/1137.

PierfrancescoSoffritti commented 6 months ago

Thanks for your PR. On second thought, I don't think it's this library's business to do URL parsing. Users of the library should be responsible for handling this.

We don't want to have to maintain logic that parses URLs.

MahmoudMabrok commented 6 months ago

Sad to hear this. thanks so much for comments and review.

I will close the PR.