search

Pierrad / obsidian-github-copilot

A bridge between Obsidian and Github Copilot
Apache License 2.0
155 stars 10 forks source link

Suggestions don't disappear when navigating with hjkl in vim mode #35

Closed i-am-the-slime closed 3 months ago

i-am-the-slime commented 3 months ago

Describe the bug Suggestions don't disappear when navigating with hjkl in vim mode

To Reproduce

  1. Activate the VIM keybindings
  2. Get a suggestion at the end of a line, then hit escape and move the cursor anywhere
  3. The stale suggestion moves along with the cursor wherever it goes

Expected behavior The suggestion should be dismissed when moving away from the original position and potentially refresh at the new position

Screenshots

Bildschirmfoto 2024-07-30 um 11 44 29 Bildschirmfoto 2024-07-30 um 11 44 38

Obsidian and environment (please complete the following information):

Additional context Great plugin, thanks!

Pierrad commented 3 months ago

Hi @i-am-the-slime, thanks for using the plugin!

I see that you're using the v1.0.6 of the plugin, you should upgrade to the last version, in v1.0.8 I fix this bug that was also happening when not using the vim mode.

i-am-the-slime commented 3 months ago

Merci beaucoup, Pierrad. Maintenant, c'est impeccable.