Pierre-Sassoulas / django-survey

A django survey app that can export results as CSV or PDF using your native language.
GNU Affero General Public License v3.0
217 stars 145 forks source link

Update to Python 3.11/pyproject.toml/current django versions #180

Closed johanneswilm closed 1 year ago

johanneswilm commented 1 year ago

Some of this is just minor changes needed to make it work with Python 3.11.2/pip 23.0.1.

Edit: Substantial changes have been moved to https://github.com/Pierre-Sassoulas/django-survey/pull/181.

johanneswilm commented 1 year ago

@Pierre-Sassoulas Sure. The problem is I couldn't run/test it without those at all. I can make a PR just with those changes first and then make this one depend on that other one.

johanneswilm commented 1 year ago

@Pierre-Sassoulas done

Pierre-Sassoulas commented 1 year ago

I think the github workflow needs to be modified too, we still have python 3.7 and no python 3.11.

Pierre-Sassoulas commented 1 year ago

Here: https://github.com/Pierre-Sassoulas/django-survey/blob/main/.github/workflows/ci.yml#L14

johanneswilm commented 1 year ago

@Pierre-Sassoulas Oh yeah. You know there is actually also a github action plugin so that you only need to specify it in one place: https://github.com/ymyzk/tox-gh-actions

johanneswilm commented 1 year ago

@Pierre-Sassoulas I noticed you turned off github actions from running from outside contributors. I understand it is annoying for you to have to click "approve" all the time, but as far as I can tell, there is no option in github that allows me to run the github actions in my forked repo instead.

Pierre-Sassoulas commented 1 year ago

I think it's possible if you open a pull request from a branch in your repo to your own main branch.

johanneswilm commented 1 year ago

@Pierre-Sassoulas I tried doing that. It didn't work: https://github.com/johanneswilm/django-survey/pull/1 . I tried looking through the settings and googling for solutions, but found nothing.

Is there any particular reason for why you set it to requiring an approval for every single run?

Pierre-Sassoulas commented 1 year ago

Is there any particular reason for why you set it to requiring an approval for every single run?

It's the default value imposed by github to prevent bitcoin mining :)

Pierre-Sassoulas commented 1 year ago

Thank you for the multiplee upgrades, amazing !