search

Pierre-Sassoulas / django-survey

A django survey app that can export results as CSV or PDF using your native language.
GNU Affero General Public License v3.0
217 stars 145 forks source link

Bugfix on Portuguese translation #188

Closed g-normand closed 5 days ago

g-normand commented 3 months ago

I had a trouble with Portuguese translation with Django 4.2 and python 3.9 :

Capture d’écran de 2024-08-07 07-22-21

So I updated the PO and MO, tell me if it's OK for you !

g-normand commented 3 months ago

looks like there is a problem with https://pypi.org/project/django-bootstrap-form/ and distutils, but it's not linked to my PR

g-normand commented 3 months ago

LGTM, thank you. Do you want to fix the issue with setuptools due to python 3.12 in another MR first ? I won't be able to do that this week (I'm on mobile).

I let you do that in the next weeks, there is no rush !

Pierre-Sassoulas commented 1 week ago

Hey, the main branch is fixed, sorry about the delay.

g-normand commented 6 days ago

Thanks @Pierre-Sassoulas ! Could you also update the version on pip? It's still on 1.4.7 (https://pypi.org/project/django-survey-and-report/)

Pierre-Sassoulas commented 6 days ago

We'd want to merge this one first, right ?

g-normand commented 6 days ago

@Pierre-Sassoulas sorry, I read it wrong, now it should be ok !

Pierre-Sassoulas commented 5 days ago

Seems like a recompile was necessary. I added some test so we check that it's recompiled properly too. Released in https://pypi.org/project/django-survey-and-report/1.4.8/